Open
Conversation
Update generate GGUF steps
BingxuanWang
suggested changes
Feb 18, 2024
Contributor
BingxuanWang
left a comment
BingxuanWang
left a comment
There was a problem hiding this comment.
The reason we fork a repo of llama.cpp is that current behaviour of the tokenizer in llama.cpp is slightly different from the python tokenizer. Details could be found in ggml-org/llama.cpp#4070
Maybe maintain both way could be better solution
ToshClout
approved these changes
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update generate GGUF steps, as the official PR changes can't convert to GGUF exactly