Handle cases where a model does not repeat the function signature#184
Open
XZ-X wants to merge 1 commit intodeepseek-ai:mainfrom
Open
Handle cases where a model does not repeat the function signature#184XZ-X wants to merge 1 commit intodeepseek-ai:mainfrom
XZ-X wants to merge 1 commit intodeepseek-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to handle cases where a model does not repeat the function signature.
Note that the variable
startdenotes the position of the queried function signature, and it will be set to0the function signature is not found in a model's response.Suppose that the query prompt is
If a model returns
return s.length(); }The original processing code yields
which fails to compile.
A possible fix (as proposed by this PR) is not to skip the function signature when it's not found in a model's response.
That is, instead of returning
func_prefix + '\n' + body + '\n', the function returnsquestion + '\n' + bodywhen the signature is not found.