AWS EC2 Launch Templates - Add additional commands for COOC integration #42962
+1,218
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🤖 AI-Powered Code Review AvailableYou can leverage AI-powered code review to assist with this PR! Available Commands:
|
…ec2-batch-6 # Conflicts: # Packs/AWS/Integrations/AWS/AWS.py # Packs/AWS/Integrations/AWS/AWS.yml # Packs/AWS/Integrations/AWS/AWS_test.py # Packs/AWS/Integrations/AWS/README.md # Packs/AWS/ReleaseNotes/2_1_5.md
…ec2-batch-6 # Conflicts: # Packs/AWS/Integrations/AWS/AWS.py # Packs/AWS/Integrations/AWS/AWS_test.py # Packs/AWS/Integrations/AWS/README.md # Packs/AWS/ReleaseNotes/2_2_0.md
ilaredo
requested review from
julieschwartz18
and removed request for
talihaff
…ec2-batch-6 # Conflicts: # Packs/AWS/Integrations/AWS/AWS.py # Packs/AWS/Integrations/AWS/AWS_test.py # Packs/AWS/Integrations/AWS/README.md # Packs/AWS/ReleaseNotes/2_2_0.md
Contributor
julieschwartz18
left a comment
julieschwartz18
left a comment
There was a problem hiding this comment.
@ilaredo Doc review complete. Please check the comments. Also, please regenerate the integration README file (based on updates to the YAML). In the meantime, adding the label docs-approved. Thanks!
| outputs: [ ] | ||
|
|
||
| - name: aws-ec2-launch-templates-describe | ||
| description: Describes one or more launch templates. |
Contributor
There was a problem hiding this comment.
The following lines have descriptions with a misspelling. The word "Weather" needs to be spelled "Whether":
114
161
167
173
179
542
981
987
Also, in line 9 the word "Deafult" should be spelled "Default"
Let me know if you have any questions.
| description: The principal that created the launch template. | ||
| type: string | ||
| - contextPath: AWS.EC2.LaunchTemplates.DefaultVersionNumber | ||
| description: The version number of the default version of the launch template. |
Contributor
There was a problem hiding this comment.
Suggested change
| description: The version number of the default version of the launch template. | |
| description: The default version number of the launch template. |
| description: The version number of the default version of the launch template. | ||
| type: number | ||
| - contextPath: AWS.EC2.LaunchTemplates.LatestVersionNumber | ||
| description: The version number of the latest version of the launch template. |
Contributor
There was a problem hiding this comment.
Suggested change
| description: The version number of the latest version of the launch template. | |
| description: The latest version number of the launch template. |
| description: The ID of the kernel. | ||
| required: false | ||
| - name: ebs_optimized | ||
| description: Indicates whether the instance is optimized for Amazon EBS I/O. |
Contributor
There was a problem hiding this comment.
Suggested change
| description: Indicates whether the instance is optimized for Amazon EBS I/O. | |
| description: Whether the instance is optimized for Amazon EBS I/O. |
| description: The name of the key pair. | ||
| required: false | ||
| - name: monitoring | ||
| description: Specify true to enable detailed monitoring. Otherwise, basic monitoring is enabled. |
Contributor
There was a problem hiding this comment.
Suggested change
| description: Specify true to enable detailed monitoring. Otherwise, basic monitoring is enabled. | |
| description: Set to true to enable detailed monitoring. Set to false to enable basic monitoring. |
| @@ -30,3 +30,6 @@ | |||
| - Added support for the **aws-ec2-iam-instance-profile-associations-describe** command to describe IAM instance profile associations. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| - Added support for the **aws-ec2-iam-instance-profile-associations-describe** command to describe IAM instance profile associations. | |
| - Added support for the ***aws-ec2-iam-instance-profile-associations-describe*** command to describe IAM instance profile associations. |
Contributor
There was a problem hiding this comment.
Please make sure all the commands are bold italic (***)
| @@ -30,3 +30,6 @@ | |||
| - Added support for the **aws-ec2-iam-instance-profile-associations-describe** command to describe IAM instance profile associations. | |||
| - Added support for the **aws-ec2-password-data-get** command to retrieve the encrypted administrator password for a running Windows instance. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| - Added support for the **aws-ec2-password-data-get** command to retrieve the encrypted administrator password for a running Windows instance. | |
| - Added support for the ***aws-ec2-password-data-get*** command to retrieve the encrypted administrator password for a running Windows instance. |
|
|
||
| ##### Amazon Web Services | ||
|
|
||
| - Added support for the **aws-s3-bucket-objects-list** command that list objects in an s3 bucket. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Added support for the ***aws-s3-bucket-objects-list*** command that list objects in an Amazon s3 bucket. |
commands need to be bold italic (***) - please update all commands accordingly
| ##### Amazon Web Services | ||
|
|
||
| - Added support for the **aws-s3-bucket-objects-list** command that list objects in an s3 bucket. | ||
| - Added support for the **aws-s3-bucket-delete** command, which deletes an S3 bucket. |
Contributor
There was a problem hiding this comment.
Suggested change
| - Added support for the ***aws-s3-bucket-delete*** command, which deletes an Amazon S3 bucket. |
| @@ -30,3 +30,6 @@ | |||
| - Added support for the **aws-ec2-iam-instance-profile-associations-describe** command to describe IAM instance profile associations. | |||
| - Added support for the **aws-ec2-password-data-get** command to retrieve the encrypted administrator password for a running Windows instance. | |||
| - Added support for the **aws-ec2-reserved-instances-describe** command to describe one or more Reserved Instances. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| - Added support for the **aws-ec2-reserved-instances-describe** command to describe one or more Reserved Instances. | |
| - Added support for the ***aws-ec2-reserved-instances-describe*** command to describe one or more reserved instances. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
CRTX-217216
CRTX-217311
CRTX-217313
Description
Must have