Skip to content

[MCPApiModule] Add OAuth state parameter #42967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mmhw wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[MCPApiModule] Add OAuth state parameter #42967

mmhw wants to merge 10 commits into from
+53 −15

Conversation

@mmhw
Copy link
Contributor

@mmhw mmhw commented Feb 8, 2026

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Related: CRTX-225695

Description

Updated the Generic MCP integration to add state parameter to OAuth authorization requests.

@mmhw mmhw self-assigned this Feb 8, 2026
@mmhw mmhw requested a review from dantavori February 8, 2026 13:13
@content-bot
Copy link
Contributor

content-bot commented Feb 8, 2026

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @content-bot start review - Initiate a full AI code review
  • @content-bot re-review - Incremental review for new commits

@github-actions
Copy link

github-actions bot commented Feb 8, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ApiModules/Scripts/MCPApiModule
   MCPApiModule.py3227676%101, 197–199, 221, 229, 237–241, 243–245, 247, 262, 266–268, 310, 313, 316, 319–320, 323, 326, 328, 338, 342–345, 379–381, 383–384, 401, 411–417, 472–473, 482, 487, 499–504, 506, 511, 537, 539–544, 546–547, 549, 587–589, 591, 613–614, 645, 655, 673
Packs/AtlassianCloudMCP/Integrations/AtlassianCloudMCP
   AtlassianCloudMCP.py100100% 
Packs/CloudflareMCP/Integrations/CloudflareMCP
   CloudflareMCP.py10100%1–3, 5, 8, 11–15
Packs/GenericMCP/Integrations/GenericMCP
   GenericMCP.py19478%25, 27, 29, 33
Packs/GitHubMCP/Integrations/GitHubMCP
   GitHubMCP.py70100% 
TOTAL3689075% 

Tests Skipped Failures Errors Time
42 0 💤 0 ❌ 0 🔥 11.595s ⏱️

@mmhw mmhw added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Feb 10, 2026
@mmhw
Copy link
Contributor Author

mmhw commented Feb 10, 2026

@content-bot start review

@content-bot content-bot added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Feb 10, 2026
@content-bot content-bot removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Feb 10, 2026
@content-bot
Copy link
Contributor

content-bot commented Feb 10, 2026

🤖 Content AI Reviewer: Analysis started. Please wait for results...

@content-bot
Copy link
Contributor

content-bot commented Feb 10, 2026

🤖 Content-bot Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

content-bot
content-bot reviewed Feb 10, 2026
View reviewed changes
Copy link
Contributor

@content-bot content-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I've reviewed the changes and have a few minor points to address.

Please update the release notes to use internal parameter names (e.g., *state*, *insecure*) per our styling guidelines. Also, ensure the base64 module is explicitly imported in the API module script since it's referenced in the code.

Great work otherwise!

@dantavori please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@demisto demisto deleted a comment from content-bot Feb 10, 2026
@content-bot
Copy link
Contributor

content-bot commented Feb 10, 2026

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@content-bot content-bot content-bot left review comments

@dantavori dantavori Awaiting requested review from dantavori

At least 1 approving review is required to merge this pull request.

Assignees

@mmhw mmhw

Labels

ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmhw @content-bot