Skip to content

Fix Java compilation warnings#140

Merged
demoth merged 1 commit intomainfrom
codex/fix-java-compilation-warnings
Jun 19, 2025
Merged

Fix Java compilation warnings#140
demoth merged 1 commit intomainfrom
codex/fix-java-compilation-warnings

Conversation

@demoth
Copy link
Owner

@demoth demoth commented Jun 19, 2025

Summary

  • replace deprecated wrapper constructors with valueOf in Vargs
  • remove deprecated Integer constructors in rendering and audio code
  • simplify player list lookup in game exports

Testing

  • ./gradlew build -x test
  • ./gradlew test

https://chatgpt.com/codex/tasks/task_e_6854526d63cc8329932a0f275623c750

@demoth demoth requested a review from Copilot June 19, 2025 18:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Java compilation warnings by replacing deprecated wrapper constructors with their corresponding valueOf methods and simplifying the player list lookup logic.

  • Replaced deprecated Boolean, Byte, Character, Short, Integer, Long, Float, and Double constructors in Vargs.
  • Updated similar constructor calls in GameExportsImpl, Channel, and Model.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
qcommon/src/main/java/jake2/qcommon/util/Vargs.java Replaced wrapper constructors with valueOf calls.
game/src/main/java/jake2/game/GameExportsImpl.java Replaced constructor usage in player lookup with valueOf.
client/src/main/java/jake2/client/sound/lwjgl/Channel.java Replaced deprecated Integer constructor with valueOf for key.
client/src/main/java/jake2/client/render/fast/Model.java Replaced deprecated Integer constructor with valueOf for tmp.

@demoth demoth merged commit 1a1151e into main Jun 19, 2025
1 check passed
@demoth demoth deleted the codex/fix-java-compilation-warnings branch June 19, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant