Skip to content

Utilizing -fzf for tsserver responses along with regular lsp responses#5084

Merged
hsanson merged 2 commits intodense-analysis:masterfrom
stevematney:fzf-completion
Jan 25, 2026
Merged

Utilizing -fzf for tsserver responses along with regular lsp responses#5084
hsanson merged 2 commits intodense-analysis:masterfrom
stevematney:fzf-completion

Conversation

@stevematney
Copy link
Contributor

@stevematney stevematney commented Jan 8, 2026

I was really excited about the addition of #5018, but was a bit disappointed when it didn't work in my typescript project. This gets that working and unifies the display and formatting of reference responses down singular code paths, so all responses get processed if there are more output branches in the future.

@stevematney stevematney force-pushed the fzf-completion branch 3 times, most recently from e0b2d19 to 5c695e1 Compare January 8, 2026 23:14
@stevematney
Copy link
Contributor Author

stevematney commented Jan 13, 2026

I was thinking about the possibility of future FindReferences use cases, and realized that the previous code I'd written would not have leant itself at all well to the prospect of more use cases. That being the case, I reconfigured FormatResponseItem to take a response_item object that is expected to be sanitized when it gets passed in, and allowed each response case (tsserver or lsp) to handle its own configuration of that object. This allows for variation to happen at the point where it is most relevant, and opens up FindReferences to allow for any number of outliers.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions.

@hsanson hsanson merged commit f730ded into dense-analysis:master Jan 25, 2026
8 checks passed
hsanson added a commit to hsanson/ale that referenced this pull request Jan 25, 2026
* upstream/master:
  Add missing space to gcc linter (dense-analysis#4791). (dense-analysis#5088)
  Utilizing -fzf for tsserver responses along with regular lsp responses (dense-analysis#5084)
  Fix markdownlint output format (dense-analysis#5085)
  fix: replace deprecated client.request method call with colon syntax (dense-analysis#5081)
  fix vale option (dense-analysis#5086)
  fix-proselint (dense-analysis#5074)
  fix gopls without setting ale_go_gopls_init_options (dense-analysis#5059)
@stevematney stevematney deleted the fzf-completion branch January 27, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants