Merged
Conversation
jeffwidman
previously approved these changes
Feb 18, 2025
Member
jeffwidman
left a comment
jeffwidman
left a comment
There was a problem hiding this comment.
Nice, glad they finally added that!
Member
Author
|
I added a test and found that on our CI it's not working. Still this is an improvement! |
jakecoffman
commented
Feb 20, 2025
|
|
||
| func TestDependabot(t *testing.T) { | ||
| err := exec.Command("go", "build", "dependabot.go").Run() | ||
| err := exec.Command("go", "build", ".").Run() |
Member
Author
There was a problem hiding this comment.
When you build with a file, the version info isn't injected.
Member
There was a problem hiding this comment.
Ah, I remember hitting something like this at a prior employer. It was a royal pain to workaround.
jakecoffman
commented
Feb 20, 2025
| Conds: scripttest.DefaultConds(), | ||
| Cmds: Commands(), | ||
| Quiet: !testing.Verbose(), | ||
| Quiet: false, |
Member
Author
There was a problem hiding this comment.
Having it always output the failing test is helpful, making it permanent.
jeffwidman
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.24 is now injecting the build version into the binary, so we don't need to do this extra work.
I think this may also fix #233, allowing us to ask people to run
dependabot --versionto check to see if they're running an old version of the Dependabot CLI. Currently it does not work if they do thego installcommand.Also updated the installation instructions, removed a gist from a former employee.