Add missing dependencies arg to readme example#419
Merged
jeffwidman merged 1 commit intomainfrom Apr 2, 2025
Merged
Conversation
Without this, I get the following error: ```shell updater | 2025/04/01 22:28:59 ERROR Passed `nil` into T.must updater | 2025/04/01 22:28:59 ERROR /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/sorbet-runtime-0.5.11952/lib/types/_types.rb:222:in `must' updater | 2025/04/01 22:28:59 ERROR /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:87:in `block in allowed_dependencies' updater | 2025/04/01 22:28:59 ERROR /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:87:in `select' updater | 2025/04/01 22:28:59 ERROR /home/dependabot/dependabot-updater/lib/dependabot/dependency_snapshot.rb:87:in `allowed_dependencies' ``` This is because in Dependabot-Core, if it's a security update, it's required to explicitly pass in the desired `dependencies`: https://github.com/dependabot/dependabot-core/blob/c8681bf6c474567f471128fbe37383706a22c647/updater/lib/dependabot/dependency_snapshot.rb#L86-L87
jeffwidman
force-pushed
the
add-missing-dependencies-arg
branch
from
57346d8 to
7aa22c9
Compare
abdulapopoola
approved these changes
Apr 1, 2025
rickreyhsig
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, I get the following error:
This is because in Dependabot-Core, security updates are required to explicitly pass in the desired
dependencies:https://github.com/dependabot/dependabot-core/blob/c8681bf6c474567f471128fbe37383706a22c647/updater/lib/dependabot/dependency_snapshot.rb#L86-L87