fixes Python cert error connecting to pypi.org#441
Merged
jakecoffman merged 3 commits intomainfrom May 12, 2025
Merged
Conversation
Member
Author
|
Confirms this fixes the issue: #442 |
This was referenced May 9, 2025
Member
Author
|
This fix is related to dependabot/dependabot-core#12066. I verified that running Running with this branch the error does not happen. |
thavaahariharangit
approved these changes
May 12, 2025
Contributor
thavaahariharangit
left a comment
thavaahariharangit
left a comment
There was a problem hiding this comment.
I ran the cli against the repo and ensured the fix is working as expected.
landongrindheim
approved these changes
May 12, 2025
Contributor
landongrindheim
left a comment
landongrindheim
left a comment
There was a problem hiding this comment.
I'd love it if @pavera could take a look at this as well 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the necessary
KeyUsageandExtKeyUsagefields to the certificate generation function incadetails.goto ensure that the generated certificate is compatible with Python 3.10.I'm unsure what the exact requirements are but this seems to do the trick.
Trying to figure out if this is testable.
We will need to make the same change in dependabot-action.