Conversation
brettfo
force-pushed
the
dev/bretfo/test-encoding
branch
from
849a337 to
4f38fc8
Compare
| @@ -254,6 +255,11 @@ func decodeWrapper(kind string, data []byte) (actual *model.UpdateWrapper, err e | |||
|
|
|||
| // to avoid having massive base64 encoded strings in the test fixtures, replace the content with a hash | |||
| func replaceBinaryWithHash(files []model.DependencyFile) []model.DependencyFile { | |||
There was a problem hiding this comment.
This method was added for the smoke tests, which use Dependabot CLI's -o/--output to generate test fixtures. So testing.Testing() doesn't apply here, the CLI is running in "production" mode.
You should use stdout which does not have this behavior (thanks to #465) or you can start your own server to receive the API calls directly using the --api-url option.
There was a problem hiding this comment.
Thanks @brettfo for looking in to this. Based on this comment, sounds like the issue is ultimately because we're reading output from the scenario file and the BOM changes are now expected behavior. We'll need to change to either read from stdout or implement an API server
|
Closing per @rhyskoedijk's comment. This is working as expected. |
4 participants
Test-only code shows behavior changes in production. Based on the comment, this should be fixed for production scenarios.