fix graph command not working without experiment enabled#502
Merged
jakecoffman merged 2 commits intomainfrom Sep 4, 2025
Merged
fix graph command not working without experiment enabled#502jakecoffman merged 2 commits intomainfrom
jakecoffman merged 2 commits intomainfrom
Conversation
honeyankit
previously approved these changes
Sep 2, 2025
brrygrdn
approved these changes
Sep 4, 2025
Comment on lines
-17
to
-21
| var graphSupportedEcosystems = []string{ | ||
| "bundler", | ||
| "go_modules", | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
👍🏻 - this no longer makes sense to restrict as you say, I'm in queue to merge the new version of the experiment which means most ecosystems will now have a base-line capability vs the previous approach where we had to do enabling work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we can now see the jsonl output in stdout from this command:
Although it's a bit nicer to read if you use the -o flag to generate a smoke test:
I also removed the restriction in ecosystems. It's an experiment so if it doesn't work then it doesn't work 😄