Differentiate between cmd input and model input exclusivity#507
Differentiate between cmd input and model input exclusivity#507ahokinson wants to merge 1 commit intodependabot:mainfrom ahokinson:fix/input-types
Conversation
jakecoffman
left a comment
There was a problem hiding this comment.
The CLI arguments, e.g. dependabot update go_modules dependabot/cli, are meant as a shortcut to providing an input file. It makes it easier to share an issue reproduction, or someone new to Dependabot can get started right away.
The rest of the input methods are all ways to pass a single input job file and should be mutually exclusive. If not, we'd have to merge them all together and arbitrarily decide order of importance.
Can you tell me a bit more about what problem you're trying to solve?
|
So I can clarify two things, what I am trying to fix here and what I am experiencing in my own use of the CLI. What I am trying to fix with this PR: What I experiencing trying to use the CLI: In order to debug my own problems, I have been trying to play with flags to add control to how the containers communicate with each other. The |
|
Ah ok, the different flag names are a bit confusing here. The API server you are having trouble with in #377 gets its settings from environment variables. I will close this and respond in #377 with some things you can try in a bit. |
In #506, I noticed that parsing flags and model input to the Dependabot job had some scenarios that collide.
This fix ignores the
-for--fileflags when deciding if the commandhasArgumentsbecause this would meanhasFilewas specified by these arguments, and therefore should only check for additional arguments. There might be some more idiomatic way to do this...I also excluded
hasServerfrom the args checker because it also collides withhasArguments.Still need to address how Model Input is created from these new possible scenarios.
Would love feedback, @jakecoffman.