Merged
Conversation
Member
|
Looks like a smoke test is catching an issue. Otherwise looks good so far! |
alhss
force-pushed
the
alhss/support-for-new-pr-format
branch
from
42ec787 to
3118be9
Compare
Contributor
Author
|
Added two marshal methods to preserve backward compatibility with the updater. When unmarshaling old format [[...]], we flatten it internally to [...] , but the updater still expects the old nested array format. These marshal methods detect the format and re-wrap flat entries as [[...]] when sending to the updater since this method cannot handle unflatten data of the old format. |
jakecoffman
approved these changes
Oct 20, 2025
Member
jakecoffman
left a comment
jakecoffman
left a comment
There was a problem hiding this comment.
cool cool, nice work preserving the formatting when marshaling
mburumaxwell
added a commit
to mburumaxwell/paklo
that referenced
this pull request
Jan 26, 2026
Add `pr-number` field to job schema while maintaining backward compatibility with legacy storage format. Reference dependabot/cli#516 and dependabot/cli#527
mburumaxwell
added a commit
to mburumaxwell/paklo
that referenced
this pull request
Jan 26, 2026
Add `pr-number` field to job schema while maintaining backward compatibility with legacy storage format. Reference dependabot/cli#516 and dependabot/cli#527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for a new existing pull request format while maintaining full backward compatibility. The
ExistingPRstruct now serves as a superset capable of representing both individual dependencies and the new format PRs with nested dependencies. CustomUnmarshalJSONandUnmarshalYAMLmethods handle automatic format detection and parsing for both the new format (PRs withpr-number+ nesteddependencies) and legacy format (nested[][]ExistingPRarrays).