remove command from top-level, handle recreate jobs#532
Merged
jakecoffman merged 2 commits intomainfrom Nov 3, 2025
Merged
Conversation
Member
Author
|
Smoke test failures are unrelated. |
brrygrdn
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I thought having the
commandat the top-level of smoke-tests would be the right move, but then we realized that the Updater would like to know what the command was to run.So it ended up being duplicated, this removes the top-level "command" parameter.
This also adds a handler for the
recreateandsecuritycommands which is new, but I think next step is we simply invokebin/runand have the Updater figure out what it wants to run.