Merged
Conversation
Check in a .golangci.yml so the repo has a consistent linter setup. Uses the v2 config format with the standard linter set plus bodyclose, errorlint, gocritic, gosec, misspell, noctx, and prealloc. Closes #561
JamieMagee
force-pushed
the
jamiemagee/add-golangci-lint-config
branch
from
2fd5445 to
6bf7b64
Compare
truggeri
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
.golangci.yml(v2 format) to give the repo a consistent linter setup.The config uses the
standarddefault set (errcheck,govet,ineffassign,staticcheck,unused) and turns on a few extras that catch real bugs without being too noisy:bodyclose— unclosed HTTP response bodieserrorlint— incorrect error wrappinggocritic— common code style issuesgosec— security problemsmisspell— typosnoctx— missing context in HTTP/net callsprealloc— slice preallocation hintsWe already have
golangci-lintin the Brewfile but no config, so everyone either runs different linters or none at all. This gets us to a shared baseline.There are ~55 existing findings (mostly
errcheck). Fixing those and wiring this into CI are separate follow-ups.Closes #561