Attach dependencies to the DependencyFile in go_modules's FileParser#12837
Merged
Attach dependencies to the DependencyFile in go_modules's FileParser#12837
dependencies to the DependencyFile in go_modules's FileParser#12837Conversation
brrygrdn
reviewed
Aug 14, 2025
brrygrdn
reviewed
Aug 14, 2025
brrygrdn
previously approved these changes
Aug 14, 2025
…t statements. let's try undoing it.
…b.com:dependabot/dependabot-core into phillmv/attach-dependencies-to-dep-file-in-go
brrygrdn
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Per https://github.com/github/dependency-graph/issues/7121,
[for those of you who do not work at GitHub, the above link describes an effort we're undergoing to refactor technical debt and start using dependabot-core to parse dependencies for our dependency graph service.]
This PR attaches Go dependencies to the associated
DependencyFileinDependabot::GoModules::FileParser.Back in #12768 we introduced
DependencyFile#dependenciesand in this PR we extend its usage to thego_modulesecosystem, in support of theDependencySubmissionfunctionality introduced in #12734Anything you want to highlight for special attention from reviewers?
I feel its pretty straightforward!
How will you know you've accomplished your goal?
Tests pass, testing in production.
Checklist