Skip to content

Attach dependencies to the DependencyFile in go_modules's FileParser#12837

Merged
brrygrdn merged 8 commits intomainfrom
phillmv/attach-dependencies-to-dep-file-in-go
Aug 15, 2025
Merged

Attach dependencies to the DependencyFile in go_modules's FileParser#12837
brrygrdn merged 8 commits intomainfrom
phillmv/attach-dependencies-to-dep-file-in-go

Conversation

@phillmv
Copy link
Member

@phillmv phillmv commented Aug 13, 2025

What are you trying to accomplish?

Per https://github.com/github/dependency-graph/issues/7121,

[for those of you who do not work at GitHub, the above link describes an effort we're undergoing to refactor technical debt and start using dependabot-core to parse dependencies for our dependency graph service.]

This PR attaches Go dependencies to the associated DependencyFile in Dependabot::GoModules::FileParser.

Back in #12768 we introduced DependencyFile#dependencies and in this PR we extend its usage to the go_modules ecosystem, in support of the DependencySubmission functionality introduced in #12734

Anything you want to highlight for special attention from reviewers?

I feel its pretty straightforward!

How will you know you've accomplished your goal?

Tests pass, testing in production.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: go:modules Golang modules label Aug 13, 2025
@phillmv phillmv marked this pull request as ready for review August 14, 2025 16:25
@phillmv phillmv requested a review from a team as a code owner August 14, 2025 16:25
brrygrdn
brrygrdn previously approved these changes Aug 14, 2025
Copy link
Contributor

@brrygrdn brrygrdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM

EDIT: Ah damn, it looks like CI is unhappy - my PR build off this didn't fail in the same way so it might be a flake?

@brrygrdn brrygrdn self-requested a review August 14, 2025 17:09
@brrygrdn brrygrdn merged commit 5fc328e into main Aug 15, 2025
81 checks passed
@brrygrdn brrygrdn deleted the phillmv/attach-dependencies-to-dep-file-in-go branch August 15, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: go:modules Golang modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants