Skip to content

removed handling two data types from API#13575

Closed
alhss wants to merge 1 commit intomainfrom
alhss/remove-2-format-accommodation
Closed

removed handling two data types from API#13575
alhss wants to merge 1 commit intomainfrom
alhss/remove-2-format-accommodation

Conversation

@alhss
Copy link
Contributor

@alhss alhss commented Nov 17, 2025

related to : https://github.com/github/dependabot-api/pull/7404

What are you trying to accomplish?

Since i removed the above feature flag and made the array of objects the default data format there's no need to keep both handling both data formats.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@alhss alhss marked this pull request as ready for review November 17, 2025 21:07
@alhss alhss requested a review from a team as a code owner November 17, 2025 21:07
@alhss alhss requested a review from jakecoffman November 17, 2025 21:07
@alhss alhss marked this pull request as draft November 17, 2025 21:16
@alhss
Copy link
Contributor Author

alhss commented Nov 17, 2025

i'm thinking about leaving the function as it is because a lot of tests depends on the older format

@alhss alhss closed this Mar 3, 2026
@alhss alhss reopened this Mar 3, 2026
@alhss alhss closed this Mar 3, 2026
@alhss alhss deleted the alhss/remove-2-format-accommodation branch March 3, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant