Skip to content

Remove beta ecosystems feature flag for pre-commit#14341

Merged
AbhishekBhaskar merged 1 commit intomainfrom
abhishekbhaskar/remove-pre-commit-from-beta
Mar 3, 2026
Merged

Remove beta ecosystems feature flag for pre-commit#14341
AbhishekBhaskar merged 1 commit intomainfrom
abhishekbhaskar/remove-pre-commit-from-beta

Conversation

@AbhishekBhaskar
Copy link
Contributor

What are you trying to accomplish?

This PR removes the check for enabling beta ecosystem enable_beta_ecosystems flag for pre-commit.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@AbhishekBhaskar AbhishekBhaskar self-assigned this Mar 3, 2026
@AbhishekBhaskar AbhishekBhaskar requested a review from a team as a code owner March 3, 2026 02:37
Copilot AI review requested due to automatic review settings March 3, 2026 02:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the “beta ecosystems” gating for the pre-commit ecosystem so that fetching .pre-commit-config.* files is no longer blocked by the enable_beta_ecosystems / ALLOW_BETA_ECOSYSTEMS check.

Changes:

  • Remove the beta-ecosystem guard and its “PreCommit support is currently in beta…” error from Dependabot::PreCommit::FileFetcher#fetch_files.
  • Update the pre-commit file fetcher spec to stop registering the beta experiment and to remove the “beta disabled” failure-case coverage.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pre_commit/lib/dependabot/pre_commit/file_fetcher.rb Removes the beta feature-flag gate so file fetching proceeds unconditionally.
pre_commit/spec/dependabot/pre_commit/file_fetcher_spec.rb Removes now-obsolete experiment setup and the spec asserting the beta-disabled error path.

@AbhishekBhaskar AbhishekBhaskar force-pushed the abhishekbhaskar/remove-pre-commit-from-beta branch from d97be4f to bed8e0f Compare March 3, 2026 21:16
@AbhishekBhaskar AbhishekBhaskar merged commit 2bf1c78 into main Mar 3, 2026
181 of 229 checks passed
@AbhishekBhaskar AbhishekBhaskar deleted the abhishekbhaskar/remove-pre-commit-from-beta branch March 3, 2026 21:49

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre_commit/lib/dependabot/pre_commit/file_fetcher.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants