Skip to content

nuget: switch NuGetUpdater target framework to net10.0#14345

Merged
JamieMagee merged 1 commit intomainfrom
nuget/upgrade-to-net10
Mar 3, 2026
Merged

nuget: switch NuGetUpdater target framework to net10.0#14345
JamieMagee merged 1 commit intomainfrom
nuget/upgrade-to-net10

Conversation

@JamieMagee
Copy link
Member

What are you trying to accomplish?

The SDK was already at 10.0 but the project still targeted net9.0, so this catches the target framework up and pulls in the latest SupportedFrameworks.cs (which adds the browser platform TFMs upstream missed locally).

Anything you want to highlight for special attention from reviewers?

The test files still reference net9.0 in their fixture data -- that's intentional since those represent projects Dependabot is analyzing, not the tool itself.

How will you know you've accomplished your goal?

CI builds green; dotnet build NuGetUpdater.sln compiles with zero errors on net10.0.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@JamieMagee JamieMagee requested a review from a team as a code owner March 3, 2026 06:42
Copilot AI review requested due to automatic review settings March 3, 2026 06:42
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Mar 3, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the NuGetUpdater native helper to target .NET 10 (matching the already-updated SDK) and syncs the supported TFM list with upstream, including newly added *-browser TFMs.

Changes:

  • Bump NuGetUpdater common target framework from net9.0 to net10.0.
  • Update helper build script to publish the CLI for net10.0.
  • Add net8.0-browser, net9.0-browser, and net10.0-browser to the supported frameworks list.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/FrameworkChecker/SupportedFrameworks.cs Adds browser platform TFMs for net8/net9/net10 and includes them in the supported framework list.
nuget/helpers/lib/NuGetUpdater/Directory.Common.props Updates CommonTargetFramework to net10.0 for the NuGetUpdater solution.
nuget/helpers/build Publishes NuGetUpdater.Cli targeting net10.0.

@JamieMagee JamieMagee force-pushed the nuget/upgrade-to-net10 branch from 87c97f3 to a0418b8 Compare March 3, 2026 18:47
@JamieMagee JamieMagee enabled auto-merge March 3, 2026 19:51
@JamieMagee JamieMagee merged commit 508f0c1 into main Mar 3, 2026
250 of 274 checks passed
@JamieMagee JamieMagee deleted the nuget/upgrade-to-net10 branch March 3, 2026 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: dotnet:nuget NuGet packages via nuget or dotnet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants