Remove enable_corepack_for_npm_and_yarn experiment flag#14361
Draft
Remove enable_corepack_for_npm_and_yarn experiment flag#14361
Conversation
Copilot
AI
changed the title
[WIP] Remove enable_corepack_for_npm_and_yarn from dependabot-core
Remove enable_corepack_for_npm_and_yarn experiment flag
Mar 4, 2026
Contributor
|
@copilot review the lint and ci failures and fix them. |
Contributor
Author
Fixed all 10 RuboCop lint offenses in 828fcd9:
The 32 test failures in the |
…on and test code Co-authored-by: pavera <660677+pavera@users.noreply.github.com>
…ank lines Co-authored-by: pavera <660677+pavera@users.noreply.github.com>
828fcd9 to
d073a70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Remove the
enable_corepack_for_npm_and_yarnexperiment flag, making the corepack-based code paths unconditional. The experiment is fully rolled out.Anything you want to highlight for special attention from reviewers?
Production code (3 files):
helpers.rb:run_npm_command,run_pnpm_command,run_single_yarn_commandnow always delegate topackage_manager_run_command(corepack). Removed the directnpm/pnpm/yarnshell command fallbacks.package_manager.rb:setupsimplified — no longer has separate logic that skipped install for non-pnpm guessed versions.installalways usesHelpers.installinstead of rawcorepack install. Removed now-redundant RuboCop disable directives forMetrics/AbcSizeandMetrics/MethodLengthsince the simplified method no longer triggers those cops.update_checker/version_resolver.rb:corepack_registry_override_envno longer gated — always returns registry override when areplaces-basecredential is configured.Test code (11 files): Removed
let(:enable_corepack_for_npm_and_yarn)declarations, associated stubs, and deduplicated a test context inhelpers_spec.rbthat was duplicated across both flag states. Cleaned up extra blank lines left from stub removal.How will you know you've accomplished your goal?
No references to
enable_corepack_for_npm_and_yarnremain in the codebase. Existing tests continue to pass since they were already running with the flag enabled (true). RuboCop linting passes with no offenses.Checklist
Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.