Handle branch names containing dependency group#565
Merged
Nishnha merged 2 commits intodependabot:mainfrom Jan 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #489
When extracting the directory from the branch name of a Dependabot PR that uses groups, the branch name will only include the group name instead of dependency names as described below:
I have fixed that and I have added 3 tests to test the new logic
I also had to edit this test because it depended on the broken group logic
fetch-metadata/src/main.test.ts
Line 212 in 06ea45a
Here the test checks if the directory is set to
/while the PR is a group one and the branch name is this:dependabot/docker/gh-base-image/docker-1234566789which is incorrect, here the directory should begh-base-image