fix: Improve thread safety issue #7338 alternative #7367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnou
force-pushed
the
bugfix/thread_safe_collections_v2
branch
from
e336cdf to
4fccbec
Compare
This was referenced Jan 30, 2025
Closed
Collaborator
|
@johnou thank you for the PR. Really appreciate this contribution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Improve thread safety to avoid possible issues with timsort.
ConcurrentHashMap.newKeySet() uses weakly consistent iterators that do not fail on concurrent modifications
Related issues
Have test cases been added to cover the new functionality?
no