Skip to content

Conversation

@adevade
Copy link
Contributor

@adevade adevade commented Feb 4, 2026

This changes the default value to use the current LTS release, and can still be overridden by the user by setting for example 24.x.

It passes the --lts option instead of a version number, so it will be kept up to date when new Node versions are released. See fmn install help for usage.

Let me know if anything is missing. It's my first contribution to the project.


  • Bug fix #…?

  • New feature?

  • BC breaks?

  • Tests added?

  • Docs added?

    Please, regenerate docs by running next command:
    $ php bin/docgen
    

Copilot AI review requested due to automatic review settings February 4, 2026 11:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Node.js provisioning recipe to default to installing the current Node LTS via fnm, rather than pinning a specific major version.

Changes:

  • Change node_version default from 23.x to --lts in the Node provisioning recipe.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

use function Deployer\Support\escape_shell_argument;

set('node_version', '23.x');
set('node_version', '--lts');
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates the default for node_version, but the generated docs are now stale. docs/recipe/provision/nodejs.md still shows the default value as '23.x' (see around its "Default value" block). Please regenerate docs (php bin/docgen) and include the updated docs in this PR.

Suggested change
set('node_version', '--lts');
set('node_version', '23.x');

Copilot uses AI. Check for mistakes.
use function Deployer\Support\escape_shell_argument;

set('node_version', '23.x');
set('node_version', '--lts');
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting to --lts makes provisioning time-dependent (the installed Node version will change when the LTS line advances), which can reduce reproducibility and introduce unexpected changes on reprovisioning. Consider defaulting to an explicit LTS major (and documenting --lts as an opt-in override) if deterministic builds/environments are important for this recipe.

Copilot uses AI. Check for mistakes.
@antonmedv antonmedv merged commit 3d328b6 into deployphp:master Feb 4, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants