Open
Conversation
|
Maintainers, could you merge this PR? feh is the only program that is working well for me to make montages of large image sets and the black bars kind of kill it. So close to a perfect implementation. |
|
I can confirm that building from source with these commits applied produces the intended behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are black horizontal 5px wide stripes between rows in montage mode. This happens because there are additional 5px added to height for index mode text.
These gaps definitely shouldn't appear in montage mode as no text being printed there, and it makes usage of
--limit-heightflag hard because of 5px added every row.Fixed by adding condition to add text_area_h to tot_thumb_h only in index mode.
Example with 4 separate images


--thumb-width 256 --thumb-height 256 --limit-width 512Before:
After: