Add force-conversion option to skip imlib2 image loading and directly try to convert the image instead#786
Open
lazypingu wants to merge 3 commits intoderf:masterfrom
Open
Add force-conversion option to skip imlib2 image loading and directly try to convert the image instead#786lazypingu wants to merge 3 commits intoderf:masterfrom
lazypingu wants to merge 3 commits intoderf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option
force-conversionwhich skips the regularimlib2image loading before a conversion will be attempted.This might be helpful in cases where
imlib2is able to load the image but e.g. just a tiny thumbnail. This would prevent a further conversion, since the image was loaded successfully.I faced this with
.NEFraw files of aNikon Z7 IIcamera.With
force-conversionenabled,fehwill directly try to convert withdcraworimage-magick.Since
force-conversiononly makes sense with enabledimage-conversion, the latter option will be checked and set to zero if missing or negative.