Add episode image support and Podcasting 2.0 value tag#15
Open
ChadFarrow wants to merge 7 commits intodergigi:masterfrom
Open
Add episode image support and Podcasting 2.0 value tag#15ChadFarrow wants to merge 7 commits intodergigi:masterfrom
ChadFarrow wants to merge 7 commits intodergigi:masterfrom
Conversation
Add support for extracting and displaying episode images in RSS feeds using the itunes:image tag. Images are extracted from Nostr post r tags (reference/resource tags), image tags, or content URLs. Changes: - Add imageUrl field to MediaEvent interface - Update NostrService.transformToMediaEvent to extract image URLs - Update PodcastFeedGenerator.extractImage to check r tags, image tags, and content - Add itunes:image tag to each episode item in RSS feed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove duplicate URLs from the RSS feed for each episode. The media:content tag is redundant since the enclosure tag is all that podcast apps need to download media files. Changes: - Removed media:content tag from episode items in PodcastFeedGenerator - Media URL now only appears in the required enclosure tag and description 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ems" This reverts commit 01697e8.
Contributor
|
@renoschubert is attempting to deploy a commit to the dergigi's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
Thanks for contributing! Please resolve the conflict and I'll have a look 🙏 |
added 2 commits
October 19, 2025 17:29
…lue tag feature - Fixed TypeScript errors by using correct NostrService methods - Merged episode images (itunes:image tags) with value tags (podcast:value) - Updated to use extractValueSplitFromEvent() and fetchZapProfiles() - Removed references to non-existent profile.nodeid property - Both sync and async versions now support both features
- Resolved conflicts by keeping the advanced PodcastFeedGenerator implementation - Combines episode image support with podcast value tag features - Uses NostrProfile and NDKEvent types for better functionality - Includes both sync and async feed generation methods
Author
|
I think I fixed the issue but I don't really know what I'm doing :) |
Removed extra closing brace at line 384 in PodcastFeedGenerator.ts that was causing a parsing error and preventing the build from completing successfully. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Fixed! The build was failing due to a syntax error - there was an extra closing brace at line 384 in Changes made:
The PR is ready to merge! |
Owner
|
…file support Resolved merge conflict in PodcastFeedGenerator.ts to keep both: - Episode image support (<itunes:image> tags) - Updated value tag support (keysend with nodeid priority) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Should be fixed now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<itunes:image>and<podcast:image>tagsimage,rtags) and content URLsChanges
imageUrlfield toMediaEventtypeNostrServiceto checkrtags and contentextractImage()method toPodcastFeedGenerator<podcast:value>tagTest plan
🤖 Generated with Claude Code