Adds details about X.com posts when hovering over an X link. #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sad4whattt
commented
Feb 1, 2026
sad4whattt
commented
11k
requested changes
Feb 3, 2026
Contributor
11k
left a comment
11k
left a comment
There was a problem hiding this comment.
I think the extra padding you added to the container makes the content area too narrow and the text more difficult to read. Also, there's an issue where text without spaces overflows. You can test against one of Destiny's latest posts.
Contributor
There was a problem hiding this comment.
Can you undo the changes to this file? It's copy-pasted, so I prefer to leave it as-is. It's in .prettierignore for this reason, too.
| try { | ||
| const result = await this.xComOEmbedService.getOEmbed(xcomMatch[1]); | ||
|
|
||
| const container = document.createElement('div'); |
Contributor
There was a problem hiding this comment.
Can you extract some of the common logic for building a container div and instantiating the tooltip instance to a separate function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.