Skip to content

[iOS] Fix WebView.Reload() with HtmlWebViewSource returning WebNavigationResult.Failure #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[iOS] Fix WebView.Reload() with HtmlWebViewSource returning WebNavigationResult.Failure #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
138797f
fix added
devanathan-vaithiyanathan Jun 23, 2025
397a2e8
Revert "fix added"
devanathan-vaithiyanathan Jun 23, 2025
2f47fee
Merge branch 'dotnet:main' into main
devanathan-vaithiyanathan Jun 25, 2025
f3b39cd
Merge branch 'dotnet:main' into main
devanathan-vaithiyanathan Jun 26, 2025
3d75b12
Merge branch 'dotnet:main' into main
devanathan-vaithiyanathan Jul 1, 2025
97cd6e4
Initial plan
Copilot Jul 11, 2025
e24f1b8
Fix iOS WebView.Reload() with HtmlWebViewSource issue
Copilot Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Core/src/Platform/iOS/WebViewExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,21 @@ public static void UpdateGoForward(this WKWebView platformWebView, IWebView webV

public static void UpdateReload(this WKWebView platformWebView, IWebView webView)
{
platformWebView?.Reload();
if (platformWebView == null)
return;

// For HTML sources, we need to reload the content from the source
// since WKWebView.Reload() doesn't work with LoadHtmlString
if (webView.Source != null && platformWebView is IWebViewDelegate webViewDelegate)
{
// Simply reload the source, this will work for both URL and HTML sources
webView.Source.Load(webViewDelegate);
}
else
{
// Fallback to standard reload
platformWebView.Reload();
}
}

internal static void UpdateCanGoBackForward(this WKWebView platformWebView, IWebView webView)
Expand Down
107 changes: 107 additions & 0 deletions src/Core/tests/DeviceTests/Handlers/WebView/WebViewHandlerTests.iOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
using Microsoft.Maui.Handlers;
using WebKit;
using System.Threading.Tasks;
using System;
using Microsoft.Maui.Controls;
using System.Threading;
using Xunit;

namespace Microsoft.Maui.DeviceTests
{
Expand All @@ -10,5 +15,107 @@ WKWebView GetNativeWebView(WebViewHandler webViewHandler) =>

string GetNativeSource(WebViewHandler webViewHandler) =>
GetNativeWebView(webViewHandler).Url.AbsoluteString;

[Fact(DisplayName = "Reload with HtmlWebViewSource should succeed")]
public async Task ReloadWithHtmlWebViewSourceShouldSucceed()
{
var webView = new WebView();
var htmlSource = new HtmlWebViewSource
{
Html = "<html><body><h1>Test Page</h1><p>Initial content</p></body></html>"
};

webView.Source = htmlSource;

var loadTcs = new TaskCompletionSource<WebNavigationResult>();
var reloadTcs = new TaskCompletionSource<WebNavigationResult>();
var navigatedCount = 0;

webView.Navigated += (sender, args) =>
{
navigatedCount++;
if (navigatedCount == 1)
{
// First navigation (initial load)
loadTcs.TrySetResult(args.Result);
}
else if (navigatedCount == 2)
{
// Second navigation (reload)
reloadTcs.TrySetResult(args.Result);
}
};

await InvokeOnMainThreadAsync(async () =>
{
var handler = CreateHandler<WebViewHandler>(webView);

// Wait for initial load to complete
var loadResult = await loadTcs.Task.WaitAsync(TimeSpan.FromSeconds(10));
Assert.Equal(WebNavigationResult.Success, loadResult);

// Now test reload
webView.Reload();

// Wait for reload to complete
var reloadResult = await reloadTcs.Task.WaitAsync(TimeSpan.FromSeconds(10));

// This should succeed, not fail
Assert.Equal(WebNavigationResult.Success, reloadResult);
});
}

[Fact(DisplayName = "Reload with UrlWebViewSource should still work")]
public async Task ReloadWithUrlWebViewSourceShouldWork()
{
// Skip test if no internet
if (await AssertionExtensions.SkipTestIfNoInternetConnection())
return;

var webView = new WebView();
var urlSource = new UrlWebViewSource
{
Url = "https://www.example.com"
};

webView.Source = urlSource;

var loadTcs = new TaskCompletionSource<WebNavigationResult>();
var reloadTcs = new TaskCompletionSource<WebNavigationResult>();
var navigatedCount = 0;

webView.Navigated += (sender, args) =>
{
navigatedCount++;
if (navigatedCount == 1)
{
// First navigation (initial load)
loadTcs.TrySetResult(args.Result);
}
else if (navigatedCount == 2)
{
// Second navigation (reload)
reloadTcs.TrySetResult(args.Result);
}
};

await InvokeOnMainThreadAsync(async () =>
{
var handler = CreateHandler<WebViewHandler>(webView);

// Wait for initial load to complete
var loadResult = await loadTcs.Task.WaitAsync(TimeSpan.FromSeconds(10));
Assert.Equal(WebNavigationResult.Success, loadResult);

// Now test reload
webView.Reload();

// Wait for reload to complete
var reloadResult = await reloadTcs.Task.WaitAsync(TimeSpan.FromSeconds(10));

// This should succeed
Assert.Equal(WebNavigationResult.Success, reloadResult);
});
}
}
}