Implement Element.tagName and Node.ownerDocument#27
Open
alanhoff wants to merge 1 commit intodevelopit:masterfrom
Open
Implement Element.tagName and Node.ownerDocument#27alanhoff wants to merge 1 commit intodevelopit:masterfrom
alanhoff wants to merge 1 commit intodevelopit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the following APIs:
Element.tagNameNode.ownerDocumentIt will allow the following code to operate correctly:
Sidenote
The best scenario would be adding
get ownerDocumenttoNodeinstead of monkey patchingElementat runtime, but currently that's impossible sinceNodeis isolated from the environment.