Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the translation localization inline script implementation to fix an issue where the menu wouldn't open and homepage exhibitions weren't displaying correctly in the Vapriikki site. The main change moves translation data from wp_localize_script to a custom inline script with cookiebot-ignore attributes.
- Replaced
wp_localize_scriptwith a custom footer method that addsdata-cookieconsent="ignore"attribute - Added consistent namespace prefixing with backslashes throughout the file
- Moved localization script generation to the footer to avoid conflicts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/Assets.php | Reworked translation localization implementation and added namespace prefixing |
| CHANGELOG.MD | Added entry for the TMS-1209 fix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
HPiirainen
approved these changes
Oct 22, 2025
lib/Assets.php
Outdated
| */ | ||
| public static function add_localizations_to_footer() { | ||
| $script_strings = ( new \Strings() )->s(); | ||
| $script = 'var s = ' . json_encode( $script_strings ) . ';'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projekti: Tampereen kaupunki, konsernihallinto / Tietohallintoyksikkö: Tampere multisite support
Tiketin kuvaus: TMS-1209 Vapriikki: valikko ei avaudu ja etusivulla Näyttely eivät näy oikein
Task: https://hiondigital.atlassian.net/browse/TMS-1209
Description
Rework translation localization inline script and ignore it from cookiebot.
Types of changes