Created the ActivityDetailsView screen#77
Open
Brun41v35 wants to merge 8 commits intodevpass-tech:mainfrom
Open
Created the ActivityDetailsView screen#77Brun41v35 wants to merge 8 commits intodevpass-tech:mainfrom
Brun41v35 wants to merge 8 commits intodevpass-tech:mainfrom
Conversation
pnalvarez
reviewed
Dec 14, 2022
| return stack | ||
| }() | ||
|
|
||
| private lazy var productView: UIView = { |
There was a problem hiding this comment.
Dá pra resumir com uma inicialização simples
pnalvarez
reviewed
Dec 14, 2022
| private lazy var mainStack: UIStackView = { | ||
| let stack = UIStackView() | ||
| stack.axis = .vertical | ||
| stack.distribution = .fillEqually |
There was a problem hiding this comment.
Aqui dá pra remover já que os componentes tem instrinsicContentSize
pnalvarez
reviewed
Dec 14, 2022
| return view | ||
| }() | ||
|
|
||
| private lazy var productValueView: UIView = { |
pnalvarez
reviewed
Dec 14, 2022
| private lazy var productNameLabel: UILabel = { | ||
| let label = UILabel() | ||
| label.textAlignment = .center | ||
| label.font = UIFont.boldSystemFont(ofSize: 17) |
There was a problem hiding this comment.
Dá pra salvar o tamanho da fonte numa constante
There was a problem hiding this comment.
Outra coisa: Se a label comportar conteúdo grande, bom setar o número de linhas como zero.
pnalvarez
reviewed
Dec 14, 2022
| return label | ||
| }() | ||
|
|
||
| private lazy var categoryNameLabel: UILabel = { |
pnalvarez
reviewed
Dec 14, 2022
| return label | ||
| }() | ||
|
|
||
| private lazy var productValue: UILabel = { |
pnalvarez
reviewed
Dec 14, 2022
|
|
||
| private lazy var productValue: UILabel = { | ||
| let label = UILabel() | ||
| label.font = UIFont.boldSystemFont(ofSize: 34) |
pnalvarez
reviewed
Dec 14, 2022
|
|
||
| private lazy var reportButton: UIButton = { | ||
| let button = UIButton() | ||
| button.layer.cornerRadius = 14 |
pnalvarez
reviewed
Dec 14, 2022
| private lazy var reportButton: UIButton = { | ||
| let button = UIButton() | ||
| button.layer.cornerRadius = 14 | ||
| button.backgroundColor = .systemBlue |
There was a problem hiding this comment.
Acho que seria bom usar a classe de botão que o Thyago criou.
pnalvarez
reviewed
Dec 14, 2022
| let button = UIButton() | ||
| button.layer.cornerRadius = 14 | ||
| button.backgroundColor = .systemBlue | ||
| button.setTitle("Report a issue", for: .normal) |
pnalvarez
reviewed
Dec 14, 2022
| }() | ||
|
|
||
| override var hierarchies: [BaseViewHierarchy] { | ||
| return [BaseViewHierarchy.init(parentView: self, subViews: [mainStack, reportButton]), |
pnalvarez
reviewed
Dec 14, 2022
| BaseViewHierarchy.init(parentView: productValueView, subViews: [productValue, purchaseTime])] | ||
| } | ||
|
|
||
| override var constraints: [NSLayoutConstraint] { |
There was a problem hiding this comment.
Salvar as constantes das constraints em Constants
There was a problem hiding this comment.
Pular linha e deixar um comentário pra cada componente que adiciona constraints.
pnalvarez
reviewed
Dec 14, 2022
|
|
||
| productImage.centerXAnchor.constraint(equalTo: centerXAnchor), | ||
|
|
||
| productNameLabel.centerXAnchor.constraint(equalTo: centerXAnchor), |
There was a problem hiding this comment.
Sempre é bom colocar além do centro da label os limites.
pnalvarez
reviewed
Dec 14, 2022
| reportButton.leadingAnchor.constraint(equalTo: leadingAnchor, constant: 20), | ||
| reportButton.bottomAnchor.constraint(equalTo: safeAreaLayoutGuide.bottomAnchor, constant: -15), | ||
| reportButton.trailingAnchor.constraint(equalTo: trailingAnchor, constant: -20), | ||
| reportButton.heightAnchor.constraint(equalToConstant: 56) |
There was a problem hiding this comment.
O botão poderia ter um intrinsicContentSize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created the ActivityDetailsView screen 📝
Videos
Simulator.Screen.Recording.-.iPhone.14.-.2022-12-12.at.17.23.58.mp4