-
Notifications
You must be signed in to change notification settings - Fork 73
yodev job output refactor #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
335159b
Add tests for yodev script functionality
juanbrujo b8220bd
new: Add job search from yodev.dev
juanbrujo df3c5f4
docs: Enhance comments in yodev.js for clarity
juanbrujo b72eb34
Merge branch 'devschile:master' into master
juanbrujo 4061924
style(refactor): job message formatting and response handling
juanbrujo e9ab6ae
Update scripts/yodev.js
juanbrujo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Slack blocks are being built unconditionally, but they're only used when the platform is Slack. This creates unnecessary computation when the platform is not Slack. Consider moving the blocks construction inside the Slack-specific conditional block (line 107) to avoid building data structures that won't be used in non-Slack environments.