Conversation
…proving query parameter checks
…just DeployIcon class
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
There was a problem hiding this comment.
Pull request overview
This pull request adds support for a new deployment node type (DeploymentNodeType.CD) in the CD workflow navigation and history selection logic. The changes ensure proper URL generation and query parameter handling when users navigate to CD deployment details from different parts of the application.
Key changes:
- Enhanced query parameter parsing in CD details pages to handle the new
DeploymentNodeType.CDtype - Updated URL generation in
TriggerCDNodeto includetype=CDquery parameter for non-progressing deployments - Bumped
@devtron-labs/devtron-fe-common-libdependency from 1.21.0 to 1.21.1 for compatibility
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated devtron-fe-common-lib dependency to version 1.21.1 |
| yarn.lock | Updated lockfile checksums for devtron-fe-common-lib 1.21.1 |
| triggerCDNode.tsx | Added DEPLOYMENT_STATUS import and updated URL generation to include type=CD query parameter for CD details navigation |
| CDDetails.tsx | Enhanced query parameter parsing to handle DeploymentNodeType.CD and map it to DeploymentStageType.DEPLOY |
| EnvCDDetails.tsx | Enhanced query parameter parsing to handle DeploymentNodeType.CD and map it to DeploymentStageType.DEPLOY, removed extraneous blank line |
| EnvTriggerView.tsx | Added scn-0 CSS class to deploy button icon for consistent styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/components/ApplicationGroup/Details/EnvCDDetails/EnvCDDetails.tsx
Outdated
Show resolved
Hide resolved
…onents for improved clarity and maintainability
|




Description
This pull request primarily updates logic related to deployment stage selection and navigation for CD (Continuous Deployment) workflows, with supporting dependency and UI tweaks. The most significant changes ensure that the CD workflow pages and navigation correctly handle a new deployment node type, improving filtering and routing for different deployment stages.
Deployment Stage and Navigation Logic Updates:
EnvCDDetails.tsxandCDDetails.tsxto handle the newDeploymentNodeType.CDwhen parsing query parameters, ensuring correct selection and filtering of deployment stages. [1] [2]TriggerCDNodecomponent to generate URLs that include thetype=CDquery parameter when navigating to CD details, and to use the new deployment node type in its logic.Dependency Updates:
@devtron-labs/devtron-fe-common-libfrom version1.21.0to1.21.1inpackage.jsonto ensure compatibility with new deployment node types and constants.UI/Styling Improvements:
scn-0) to the deploy button icon inEnvTriggerViewfor more consistent styling.Imports and Code Cleanliness:
DeploymentNodeTypeand related constants in affected files to support the new logic. [1] [2] [3]Fixes https://github.com/devtron-labs/sprint-tasks/issues/2719
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: