Conversation
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
There was a problem hiding this comment.
Pull request overview
This PR introduces SaaS-related functionality by adding automatic license activation via query parameter and updates the common library dependency to a beta version to support the new isSaasInstance property.
- Adds automatic license activation from URL query parameter in the ActivateLicense component
- Updates @devtron-labs/devtron-fe-common-lib from 1.21.1 to 1.21.1-beta-0 to support new SaaS features
- Adds isSaasInstance prop (temporarily hardcoded to false) to DevtronLicenseCard component
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| package.json | Updates devtron-fe-common-lib dependency to beta version 1.21.1-beta-0 |
| yarn.lock | Updates lock file with new checksums for beta version dependency |
| src/Pages/License/ActivateLicense.tsx | Adds license activation from query parameter, imports new utilities, and includes isSaasInstance prop with FIXME comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… isSaasInstance handling in ActivateLicense component
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
… in ActivateLicense component
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
|



Description
This pull request updates the license activation flow to support automatic license activation via a query parameter and improves the handling of license activation states in the UI. The most important changes are:
License Activation Flow Improvements:
ActivateLicense.tsxto automatically activate a license if a license key is present in the URL query parameters, using the newhandleActivateLicensefunction. This function handles the activation process, redirects to login on success, and displays errors if activation fails. [1] [2]isActivatingLicensestate to show a loading indicator during license activation, preventing UI flicker or user confusion.Dependency Updates:
@devtron-labs/devtron-fe-common-libto version1.22.0-beta-0inpackage.jsonto use new hooks and utilities required for the improved activation flow.Component and Data Handling Enhancements:
isSaasInstanceflag from license data to theActivateLicenseDialogcomponent for more accurate rendering based on instance type.useSearchString,LICENSE_KEY_QUERY_PARAM,showError,activateLicense) from the updated common library to support the new activation logic. [1] [2]Fixes https://github.com/devtron-labs/sprint-tasks/issues/2730
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: