Skip to content

fix: misc sentry null fix #3032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shivani170 merged 4 commits into from
Jan 2, 2026
Merged

fix: misc sentry null fix #3032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d5a426
chore: dix for git info material
shivani170 Dec 31, 2025
ddca819
fix: dockerRegistry null in UpdateTemplateConfig
shivani170 Jan 2, 2026
82b6856
fix: git info material length fix
shivani170 Jan 2, 2026
536503a
fix: updatedParentStateOrHandler optional chain added
shivani170 Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/Pages/App/CreateAppModal/UpdateTemplateConfig.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,19 @@ const UpdateTemplateConfig = ({
}

const handleCIConfigParentStateUpdate: CIConfigProps['setParentState'] = (updatedParentStateOrHandler) => {
const {
ciConfig: { dockerRegistry, dockerRepository },
} = updatedParentStateOrHandler
if (updatedParentStateOrHandler?.ciConfig) {
const {
ciConfig: { dockerRegistry, dockerRepository },
} = updatedParentStateOrHandler

handleFormStateChange({
action: CreateAppFormStateActionType.updateBuildConfiguration,
value: {
dockerRegistry,
dockerRepository,
},
})
handleFormStateChange({
action: CreateAppFormStateActionType.updateBuildConfiguration,
value: {
dockerRegistry,
dockerRepository,
},
})
}
}

const handleGitMaterialsChange: MaterialListProps['handleGitMaterialsChange'] = (updatedGitMaterial, isError) => {
Expand Down
20 changes: 10 additions & 10 deletions src/components/app/details/triggerView/BuildImageModal/GitInfoMaterial.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ const GitInfoMaterial = ({
)
// Not added source not configured check here since ideally this should not be even called at that moment and we are not adding a new material

if (!newSelectedMaterialItem.result.length) {
if (!newSelectedMaterialItem.result?.length) {
throw new Error('Unable to fetch material details')
}

Expand Down Expand Up @@ -209,17 +209,17 @@ const GitInfoMaterial = ({
updatedMaterialKeys.history = [
{
commitURL: selectedMaterial.gitURL
? createGitCommitUrl(selectedMaterial.gitURL, commitHistoryResult.Commit)
? createGitCommitUrl(selectedMaterial.gitURL, commitHistoryResult?.Commit)
: '',
commit: commitHistoryResult.Commit || '',
author: commitHistoryResult.Author || '',
date: commitHistoryResult.Date ? handleUTCTime(commitHistoryResult.Date, false) : '',
message: commitHistoryResult.Message || '',
changes: commitHistoryResult.Changes || [],
commit: commitHistoryResult?.Commit || '',
author: commitHistoryResult?.Author || '',
date: commitHistoryResult?.Date ? handleUTCTime(commitHistoryResult.Date, false) : '',
message: commitHistoryResult?.Message || '',
changes: commitHistoryResult?.Changes || [],
showChanges: true,
webhookData: commitHistoryResult.WebhookData,
isSelected: !commitHistoryResult.Excluded,
excluded: commitHistoryResult.Excluded,
webhookData: commitHistoryResult?.WebhookData,
isSelected: !commitHistoryResult?.Excluded,
excluded: commitHistoryResult?.Excluded,
},
]

Expand Down
Loading