Skip to content

feat: add manifest diff in deploy image modal#3055

Merged
AbhishekA1509 merged 3 commits intomainfrom
feat/manifest-diff-trigger-view
Feb 6, 2026
Merged

feat: add manifest diff in deploy image modal#3055
AbhishekA1509 merged 3 commits intomainfrom
feat/manifest-diff-trigger-view

Conversation

@AbhishekA1509
Copy link
Member

@AbhishekA1509 AbhishekA1509 commented Feb 5, 2026

Description

This pull request refactors how deployment configuration diff tabs are defined and used, centralizing their configuration and logic for easier maintenance and consistency across the application. It also introduces support for a "Manifest Output" tab in the pipeline deployment config diff view, including new logic for fetching and displaying manifest data, and improves error and loading state handling for this new view.

Tab configuration centralization:

  • Moved deploymentConfigDiffTabs and getDeploymentConfigDiffTabs definitions from DeploymentConfigCompare/utils.ts to Pages/Shared/constants.ts and Pages/Shared/utils.ts, and exposed them via Pages/Shared/index.ts for use throughout the app. [1] [2] [3] [4] [5] [6]

Manifest Output tab support:

  • Added logic to usePipelineDeploymentConfig to handle the "Manifest Output" tab, including fetching manifest data for different deployment scenarios and integrating it into the diff view. [1] [2] [3] [4] [5]
  • Updated PipelineConfigDiff and its types to support the new tab and conditionally adjust sorting and scope variable configuration based on the active tab. [1] [2] [3] [4]

Enhanced error and loading state handling:

  • Improved error and loading state logic to account for the manifest view, ensuring accurate feedback when manifest data is being fetched or encounters errors.

User experience improvements:

  • Added help text for the manifest view to clarify its behavior and limitations to users.

These changes make the deployment config diff views more robust, maintainable, and user-friendly.

Fixes https://github.com/devtron-labs/sprint-tasks/issues/2813

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

QA

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@AbhishekA1509 AbhishekA1509 self-assigned this Feb 5, 2026
Copilot AI review requested due to automatic review settings February 5, 2026 12:03
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions github-actions bot added the PR:Issue-verification-failed PR:Issue-verification-failed label Feb 5, 2026
@AbhishekA1509 AbhishekA1509 changed the title feat: add manifest diff in trigger view feat: add manifest diff in deploy image modal Feb 5, 2026
@github-actions
Copy link

github-actions bot commented Feb 5, 2026

Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n

@github-actions github-actions bot added PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Feb 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request refactors the deployment configuration diff tab infrastructure by centralizing tab definitions and adds support for a "Manifest Output" tab in the pipeline deployment config diff view. The changes improve maintainability by moving shared constants and utilities to a centralized location while adding new functionality for manifest comparison.

Changes:

  • Centralized deployment config diff tab definitions from component-specific files to Pages/Shared for reusability
  • Added manifest output tab functionality with new data fetching logic and error handling
  • Enhanced UI to conditionally disable sorting and scope variables for manifest view

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/Pages/Shared/constants.ts New file defining centralized deployment config diff tab constants
src/Pages/Shared/utils.ts New file with utility function to get tab configuration
src/Pages/Shared/index.ts Exports for the new shared constants and utilities
src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentConfigCompare/utils.ts Removed tab definitions that were moved to shared location
src/Pages/Applications/DevtronApps/Details/AppConfigurations/MainContent/DeploymentConfigCompare/DeploymentConfigCompare.tsx Updated imports to use centralized tab definitions
src/components/app/details/triggerView/PipelineConfigDiff/usePipelineDeploymentConfig.ts Major changes: added manifest data fetching logic, tab configuration, and enhanced error/loading state handling
src/components/app/details/triggerView/PipelineConfigDiff/types.ts Extended types to include tabConfig and navHelpText properties
src/components/app/details/triggerView/PipelineConfigDiff/PipelineConfigDiff.tsx Added logic to conditionally disable sorting for manifest view

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vivek-devtron
vivek-devtron previously approved these changes Feb 5, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2026

@AbhishekA1509 AbhishekA1509 merged commit f759f16 into main Feb 6, 2026
10 checks passed
@AbhishekA1509 AbhishekA1509 deleted the feat/manifest-diff-trigger-view branch February 6, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR:Ready-to-Review PR:Ready-to-Review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants