feat: CRP-2911 Modify AES-GCM encryption to be more robust#224
Merged
feat: CRP-2911 Modify AES-GCM encryption to be more robust#224
Conversation
ef18570 to
fccdf0d
Compare
Contributor
Author
|
This is now ready for a new review |
fspreiss
reviewed
Oct 1, 2025
Contributor
fspreiss
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments, @randombit, and for adding the respective changes also in Typescript.
fspreiss
reviewed
Oct 14, 2025
fspreiss
approved these changes
Oct 15, 2025
Contributor
fspreiss
left a comment
There was a problem hiding this comment.
Thanks for addressing all the comments, @randombit!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes include
DerivedKeyMaterialis, instead of being just the raw VetKey treated as an HKDF key, is first hashed. This prevents working backwards from aDerivedKeyMaterialto the originalVetKey.These changes are not backwards compatible. Backwards compatability could be added in the future if required (eg if the header is unknown, attempt to decrypt using the old scheme - if it works, return the recovered plaintext). The hope is that this is not required.