Open
Conversation
jcaesar
force-pushed
the
master
branch
2 times, most recently
from
5900722 to
54e4087
Compare
Contributor
Author
|
Updated for CI and merge conflict reasons. |
Open
Also stop making warnings errors. Rust is only going to add more warnings over time. Making warnings error is annoying during development, for distro packaging, and for people that just want to `cargo install record-query`. The only place where warnings should make noise is in CI, and there a `RUSTFLAGS="-D warnings"` will do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content of the PR is what it says on the tin.
The SMILE format is arguably somewhat niche, but the author of the
serde_smilecrate is well known (understatement) and I would be happy to see it supported for my "chunk messages for some Flink application into Kafka topics" needs.Imho, the core advantage of SMILE over similar formats like CBOR is that if you have a JSON structure like:
[{"asdf":42},{"asdf":43},{"asdf":44}], the string"asdf"will only be contained in the SMILE binary once.