Added py.typed to signal this project uses type declarations #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgasmith
reviewed
Feb 5, 2025
Owner
dgasmith
left a comment
dgasmith
left a comment
There was a problem hiding this comment.
Happy to merge this and push out a release. Before I do, can you manually insert a py.typed stub into an install and see how the typing goes?
I was slightly hesitant to add as I did not have a widely understood base of practice.
Open
Owner
|
@juanjosegarciaripoll gentle ping here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using opt_einsum in other projects, mypy complains that opt_einsum cannot be type checked. The reason is that for an installed library to be considered by mypy, a file py.typed must be installed in the root directory of the module.
Status