fix: allow custom key types with underlying types in Key constraint #478
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #400 The Key generic constraint previously only accepted exact types (e.g., string, int), rejecting custom types like `type UserID string` even though they have valid underlying types. Changes: - Add ~ prefix to all types in Key constraint to accept types with matching underlying types - Add reflection fallback in KeyToHash to handle custom types at runtime (type switches only match exact types) - Add TestKeyToHashCustomTypes regression test
matthewmcneely
deleted the
matthewmcneely/update-type-constraint-to-support-typed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Key generic constraint previously only accepted exact types (e.g., string, int), rejecting custom types like
type UserID stringeven though they have valid underlying types.Fixes #400
Checklist