Added an option to apply ambient occlusion (AO) blending with vertex colors#624
Open
Micheus wants to merge 2 commits intodgud:masterfrom
Open
Added an option to apply ambient occlusion (AO) blending with vertex colors#624Micheus wants to merge 2 commits intodgud:masterfrom
Micheus wants to merge 2 commits intodgud:masterfrom
Conversation
Collaborator
Author
|
Owner
|
I have let co-pilot review this, fix stuff that seems valid and write when your are done, or nothing needs fixing. |
There was a problem hiding this comment.
Pull request overview
This pull request adds an option to blend ambient occlusion (AO) with existing vertex colors rather than replacing them. The blend mode is activated by holding the CTRL modifier key when executing the ambient occlusion command, providing game developers with more flexibility when painting vertex objects.
Key changes:
- Added
blend_edge_color/4function inwings_va.erlto blend colors instead of replacing them - Implemented
blend/2function inwings_color.erlto handle color blending logic with support for both grayscale (multiplicative) and color (averaging) blend modes - Modified
wpc_ambocc.erlto detect CTRL modifier and conditionally apply blending instead of replacement
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/wings_va.erl | Added blend_edge_color/4 function and blend_color/3 helper to support blending vertex colors with new colors instead of replacing them |
| src/wings_color.erl | Added blend/2 function with support for grayscale (multiplicative) and RGB (averaging) color blending modes |
| plugins_src/commands/wpc_ambocc.erl | Modified menu text to show CTRL modifier option, added ESDL include, and updated ambient_occlusion to accept Mix parameter for conditional blending |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…colors To enable a different action via the application menu, the CTRL modifier key was used to trigger a secondary option for the AO command. This is a useful feature for those who paint vertex objects for use in games. NOTE: Added an option to apply AO blending with vertex colors. Thanks to boggers and DevEarley for the suggestion
Micheus
force-pushed
the
mv/ao-add-blend-mode
branch
from
9b7f90f to
837a476
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To enable a different action via the application menu, the CTRL modifier key was used to trigger a secondary option for the AO command. This is a useful feature for those who paint vertex objects for use in games.
NOTE:
Added an option to apply AO blending with vertex colors. Thanks to boggers and DevEarley for the suggestion