Open
Conversation
Owner
|
It's a nice start and I have no objections to this - but getting around tibbers limitation of ~ 750 hours per request will be key. There is if I'm not mistaken there is a cursor property on the consumption and pricing data returned from Tibbers GraphQL API, so using a stepper month-by-month is probably the better option. That will both assure that we don't hammer the API and get people rate limited, and the implementation app-side will be quite a bit easier. The current rate limit is 100 requests per 5 minutes, changing page a couple of times could risk that of complete reloads are performed each time. |
Author
|
Understand, will read up on tibbers quotas and update with new solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added: last-year, this-year, last-month as time periods to choose from.
Did some dynamic work on titles with new options.
Fixed an issue when no data was returned from API you would get stuck in Error state.
Im new to React, so if something is unclear or seems way off or you just don't like the PR please reach out.
regards
Hendrik