-
Notifications
You must be signed in to change notification settings - Fork 181
Fix truncated text and vertically center done text #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
you can use |
not sure if I get what you mean with this comment. |
lib/keyboard_actions.dart
Outdated
| child: Container( | ||
| padding: | ||
| EdgeInsets.symmetric(vertical: 8.0, horizontal: 12.0), | ||
| EdgeInsets.symmetric(vertical: 6.0, horizontal: 12.0), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, one fix that we can do is if the user specify a defaultDoneWidget, then this padding shouldn't be apply to that, so you are free to use your own padding.
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be even better, as it adds even more flexibility. I would keep the change of vertical padding from 8 to 6 though, otherwise users of the newly added defaultDoneButtonText will run into the same issue as in #254.
I will add a commit shortly.
|
yeah, can you update the samples please? |


Fixes #254
Before:

After:
