Skip to content

Conversation

@bbjay
Copy link
Contributor

@bbjay bbjay commented Nov 30, 2025

Fixes #254

Before:
image

After:
image

@diegoveloper
Copy link
Owner

you can use defaultDoneWidget

@bbjay
Copy link
Contributor Author

bbjay commented Dec 1, 2025

you can use defaultDoneWidget

not sure if I get what you mean with this comment.
I was using defaultDoneWidget which lead to the issue described in #254 , for which this PR is a fix.

child: Container(
padding:
EdgeInsets.symmetric(vertical: 8.0, horizontal: 12.0),
EdgeInsets.symmetric(vertical: 6.0, horizontal: 12.0),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, one fix that we can do is if the user specify a defaultDoneWidget, then this padding shouldn't be apply to that, so you are free to use your own padding.
What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be even better, as it adds even more flexibility. I would keep the change of vertical padding from 8 to 6 though, otherwise users of the newly added defaultDoneButtonText will run into the same issue as in #254.
I will add a commit shortly.

@bbjay
Copy link
Contributor Author

bbjay commented Dec 1, 2025

this will be a breaking change though, as it also lets the InkWell shrink around it.
E.g. in sample3.dart, the defaultDoneWidget changes from
image

to
image
(the screenshots are taken while pressing the button, to better show the tappable area)

But maybe it's worth it?
If you want I can adapt the samples too. Or I can revert the last commit.

@diegoveloper
Copy link
Owner

yeah, can you update the samples please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

defaultDoneWidget truncating text on iOS

2 participants