Open
Conversation
eolivelli
reviewed
Sep 21, 2020
| - name: replication-worker | ||
| image: apache/bookkeeper:latest | ||
| command: [ "/bin/bash", "/opt/bookkeeper/entrypoint.sh" ] | ||
| args: ["/opt/bookkeeper/bin/bookkeeper", "autorecovery"] |
Contributor
There was a problem hiding this comment.
this file is not needed for demo purposes,
this is a daemon that replicates data in case of lost bookies
if we want to make things simple you can drop this
Contributor
Author
There was a problem hiding this comment.
The templates are not for demo purposes but aims at giving a skeleton for real deployments IMHO.
For demo it is ok to use a plain ServerMain, no?
Contributor
There was a problem hiding this comment.
You are right, it should be better to have it.
We are not using autorecovery in production, as we usually have a small set of bookies and we are running autorecovery only manually and when needed (like when you lose definitively a machine)
so okay to keep this file now
thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic skeletons for K8s.
Idea will be to deploy bookkeeper and herddb in k8s in a custom managed fashion.
This PR is not complete and require the configuration of the link between both systems but gives some pointers about what is needed.