Add posix timing as clock ticks for non x86 systems#98
Open
julianaito wants to merge 1 commit intodigarok:masterfrom
julianaito:master
Open
Add posix timing as clock ticks for non x86 systems#98julianaito wants to merge 1 commit intodigarok:masterfrom julianaito:master
julianaito wants to merge 1 commit intodigarok:masterfrom
julianaito:master
Conversation
Closed
applemu
added a commit
to applemu/gsplus
that referenced
this pull request
Jan 13, 2021
Incorporates fix from digarok#98 Add posix timing as clock ticks for non x86 systems digarok#98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is what happens when i try to build gsplus on my OpenBSD/macppc box:
OpenBSD uses clang on powerpc,
__builtin_ppc_mftb()is a gcc-ism. As such i'm proposing to add posix timings on systems that support it, not only this is more portable, but would allow more architectures to use it; this is how retroarch does it for example.It can't be extended as-is to x86 because
__rtsdc()is a native builtin, the #define should be renamed to do so, which would require a more intrusive patch.cc @rapenne-s