-
Notifications
You must be signed in to change notification settings - Fork 572
feat: docker compose for full hosting set up #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
|
||
| // Canonical GitHub App webhook endpoint. | ||
| r.POST("/github/webhook", diggerController.GithubAppWebHook) | ||
| // Legacy webhook path kept for backward compatibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could leave this as is, but I figured we might want to standardize on /github/.
| // - "" or "/" -> "" | ||
| // - "orchestrator" -> "/orchestrator" | ||
| // - "/orchestrator/" -> "/orchestrator" | ||
| func NormalizePublicPathPrefix(raw string) string { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't strictly necessary, but helps fix common issues people may encounter with leading and trailing slashes.
|
|
||
| await saveSession({ accessToken, refreshToken, user, impersonator }); | ||
|
|
||
| // Ensure the signed-in WorkOS organization exists in dependent services. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also leave this out for now and add in a separate PR cleaning up the callback/webhook logic
| } | ||
| | Response | ||
|
|
||
| export async function requireUiAuth(request: Request): Promise<AuthResult> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we wanted to keep things simpler, we could just return a 401.
Or this could be moved to a separate PR to keep this one more focused.
🧠 Ai UsageDetails (if applicable):
IMPORTANT: Please disclose any usage of ai tooling while making this change. If you did not use any AI write "NA" below
Initial implementation pass performed via opencode + codex. Review + testing + refactoring performed both manually and via opencode.
TODO: