fix: align CSV/TSV delimiter handling across datatable and pandas #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

kusurin wants to merge 1 commit into digitalcytometry:main from kusurin:main

kusurin commented Feb 8, 2026

Summary

Align CSV/TSV delimiter selection across datatable and pandas paths.
Move duplicate checks after transpose to validate correct dimensions (genes/cells).
Add early validation for empty inputs.

Motivation

Previously, CSV files were parsed with different delimiters depending on whether datatable was installed (\t vs ,), leading to inconsistent behavior.
When the delimiter was wrong, parsing often didn’t fail immediately; errors raised later during downstream processing, making debugging difficult.
The old datatable implement validated uniqueness before transpose, which inverted the gene/cell dimension checks.

Changes

Synchronized the delimiter selection logic in pandas paths to match the datatable implementation.
Perform transpose before duplicate checks, so gene/cell uniqueness is validated on the correct axis.
Add early checks for empty cell dimension to fail fast.


          fix: align CSV/TSV delimiter handling across datatable and pandas

4c55d2f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet