Open
Conversation
adamwg
suggested changes
May 3, 2023
Contributor
adamwg
left a comment
adamwg
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
This change itself looks good, but I would like to preserve backward compatibility with the existing flag names so we don't break anyone who might be using clusterlint from scripts/CI/etc.
| cli.StringFlag{ | ||
| Name: "n, namespace", | ||
| cli.StringSliceFlag{ | ||
| Name: "n, namespaces", |
Contributor
There was a problem hiding this comment.
To preserve backward compatibility you can add namespace as another alias here. It will look a little awkward in the help, but I'd like to avoid breaking existing users. I.e.:
Name: "n, namespaces, namespace",
Author
There was a problem hiding this comment.
Sure, makes sense. Do you want to add singular aliases to the checks and groups flags too (ex.: Name: "c, checks, check",) to show a common pattern?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
[ignore-]checksflags can already be specified multiple times, now it can be done with the[ignore-]namespacesflags too. Their output is logically AND'ed.The long options have been renamed from
namespacetonamespacesfor consistency with the rest of the flags. This is a breaking change for those who use the long options but not the shorthands.The precondition of specifying either includes or excludes is still valid.