Added locked_axes() and set_locked_axes() methods for (some) joints#416
Open
Aztro-dev wants to merge 1 commit intodimforge:masterfrom
Open
Added locked_axes() and set_locked_axes() methods for (some) joints#416Aztro-dev wants to merge 1 commit intodimforge:masterfrom
locked_axes() and set_locked_axes() methods for (some) joints#416Aztro-dev wants to merge 1 commit intodimforge:masterfrom
Conversation
Contributor
Have you considered getters ?
pub fn get(&self) -> &GenericJoint {
&self.data
}
pub fn get_mut(&mut self) -> &mut GenericJoint {
&mut self.data
}or deref / derefmut derive ? |
Contributor
|
I realized some joints data are I'm curious why there is a visibility difference there @sebcrozet ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented
locked_axes(&self)for all of these structs:FixedJointPrismaticJointRevoluteJointRopeJointSphericalJointlocked_axes(&self)returns all of the axes that are currently locked by the joint.Implemented
set_locked_axes(&mut self, axes: JointAxesMask)for all of these structs:PrismaticJointRevoluteJointRopeJointSphericalJointset_locked_axes(&mut self, axes: JointAxesMask)allows you to lock axes that aren't already locked by the default axes.implemented
lock_axes(&mut self, axes: JointAxesMask)for all of these structs:PrismaticJointBuilderRevoluteJointBuilderRopeJointBuilderSphericalJointBuilderlock_axes(&mut self, axes: JointAxesMask)works exactly the same asset_locked_axes(), but is only implemented for Joint builders.Made
JointAxesMaskandJointAxispublicly available, rather than having to import them through rapier.