Fix issue where set_enabled had no effect#894
Closed
Deniskore wants to merge 1 commit intodimforge:masterfrom
Closed
Fix issue where set_enabled had no effect#894Deniskore wants to merge 1 commit intodimforge:masterfrom
Deniskore wants to merge 1 commit intodimforge:masterfrom
Conversation
Deniskore
force-pushed
the
fix-set-enabled
branch
from
2349dd5 to
6b9c2d6
Compare
Author
|
@sebcrozet I rebased my branch to the latest changes in the main branch, could you rerun CI? |
Member
|
@Deniskore Thank you. I’m investigating this further as I believe there is something deeper that is misbehaving. In theory the codepath you added should never be entered by disabled colliders at all, I’m working on figuring out why. |
Member
|
I found the root of the problem. Thank you for the PR @Deniskore, but it will be replaced by #900. |
Author
The fix works. Could you tell when you will be able to release the new version so that we can update the plugin for Bevy as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where calling
set_enabled(false)had no effect. There may be a more appropriate solution to this issue, and feedback from maintainers is needed.Related issues:
Reproduction:
Steps to reproduce the issue are clearly described in the Update to Bevy 0.17.2 PR.